Upgrade linter version

Makefile

@@ -57,7 +57,7 @@ license:
 	GOBIN=$(GOBIN) scripts/update-license.sh
 
 lint:
-	(which golangci-lint || go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.22.2)
+	(which golangci-lint || go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.31.0)
 	$(GOBIN)/golangci-lint run ./...
 
 # TODO: enable this as part of `all` target when it works for go-errors

internal/cmdexport/cmdexport_test.go

@@ -353,7 +353,7 @@ func (t *TestCase) ReplaceDIRMacro() error {
 
 	var params []string
 	for _, param := range t.params {
-		param = strings.Replace(param, "{DIR}", cwd, -1)
+		param = strings.ReplaceAll(param, "{DIR}", cwd)
 
 		params = append(params, param)
 	}

internal/testutil/testutil.go

@@ -200,8 +200,7 @@ func Replace(t *testing.T, path, old, new string) {
 		t.FailNow()
 	}
 	// update the expected contents to reflect the set command
-	b = []byte(strings.Replace(
-		string(b), old, new, -1))
+	b = []byte(strings.ReplaceAll(string(b), old, new))
 	if !assert.NoError(t, ioutil.WriteFile(path, b, 0)) {
 		t.FailNow()
 	}

internal/util/update/update_test.go

@@ -309,7 +309,7 @@ func TestCommand_Run_localPackageChanges(t *testing.T) {
 				// Update upstream to Dataset2
 				UpstreamChanges: []Content{{Data: testutil.Dataset2}},
 			}
-			//defer g.Clean()
+			defer g.Clean()
 			if !g.Init() {
 				t.FailNow()
 			}

release/formula/main.go

@@ -33,7 +33,11 @@ func main() {
 		os.Exit(1)
 	}
 	input := Input{Version: os.Args[1]}
-	input.Sha = getSha(input.Version)
+	var err error
+	input.Sha, err = getSha(input.Version)
+	if err != nil {
+		os.Exit(1)
+	}
 
 	// generate the formula text
 	t, err := template.New("formula").Parse(formula)
@@ -56,12 +60,12 @@ func main() {
 	}
 }
 
-func getSha(version string) string {
+func getSha(version string) (string, error) {
 	// create the dir for the data
 	d, err := ioutil.TempDir("", "kpt-bin")
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "%v", err)
-		os.Exit(1)
+		return "", err
 	}
 	defer os.RemoveAll(d)
 
@@ -72,7 +76,7 @@ func getSha(version string) string {
 		"https://github.com/GoogleContainerTools/kpt/archive/" + version + ".tar.gz")
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "%v", err)
-		os.Exit(1)
+		return "", err
 	}
 	defer resp.Body.Close()
 
@@ -83,24 +87,24 @@ func getSha(version string) string {
 			fmt.Fprintf(os.Stderr, "%v", err)
 			os.Exit(1)
 		}
-		defer out.Close()
 
 		if _, err = io.Copy(out, resp.Body); err != nil {
 			fmt.Fprintf(os.Stderr, "%v", err)
 			os.Exit(1)
 		}
+		out.Close()
 	}()
 
 	// calculate the sha
 	e := exec.Command("sha256sum", filepath.Join(d, version+".tar.gz"))
 	o, err := e.Output()
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "%v", err)
-		os.Exit(1)
+		return "", err
 	}
 	parts := strings.Split(string(o), " ")
 	fmt.Println("new sha: " + parts[0])
-	return parts[0]
+	return parts[0], nil
 }
 
 type Input struct {