Move cluster-related flags to live subcommand #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfarzan
reviewed
May 4, 2021
commands/livecmd.go
Outdated
| @@ -113,3 +116,21 @@ func GetLiveCommand(name string, f util.Factory) *cobra.Command { | |||
|
|
|||
| return liveCmd | |||
| } | |||
|
|
|||
| func newFactory(cmd *cobra.Command, version string) util.Factory { | |||
There was a problem hiding this comment.
util.Factory name is problematic on many levels:
a) What is this Java in 90s? :)
b) util itself is a meaningless term. Utility for WHAT? "util for X" should just be called "X" (or something with X in it), otherwise everything is a util.
Feel free to address this in a separate PR and/or create a package alias to stop the bleeding in the call sites for now.
There was a problem hiding this comment.
util.Factory comes from the kubernetes codebase, so the name is not something we can change (other than creating an import alias).
There was a problem hiding this comment.
Renamed util to cluster
frankfarzan
approved these changes
May 5, 2021
frankfarzan
pushed a commit
to frankfarzan/kpt
that referenced
this pull request
Jun 3, 2021
* Move cluster-related flags to live subcommand * Addressed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the construction of the
util.Factoryinto thelivesubcommand. This means that all flags related to a k8s cluster will now be exposed on thelivecommand instead of the top levelkptcommand.The current solution for letting users provide custom openapi schemas used the factory to allow users to fetch the k8s schema from the cluster. This PR removes this functionality completely. Depending on how we want to support this going forward, we might want to keep the functionality for reading openapi schemas from disk.
Fixes: #1886