kpt fn render ensures validators don't mutate resources
#1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore this PR for now, @Shell32-Natsu identified an issue with this, so I am going to fix that. |
droot
force-pushed
the
fn-render-split-validators
branch
from
87e281c
to
cbe0210
Compare
internal/cmdrender/executor.go
Outdated
|
|
||
| // runMutators runs a set of mutators functions on given input resources. | ||
| func (pn *pkgNode) runMutators(ctx context.Context, hctx *hydrationContext, input []*yaml.RNode) ([]*yaml.RNode, error) { | ||
| const op errors.Op = "pipeline.runMutators" |
There was a problem hiding this comment.
For this op, since we don't want to expose internal implementation details to users, I suspect does it really have a use case? Is it only used in debug? Is there a debug mode for kpt? And why don't we directly add a real stack trace here?
There was a problem hiding this comment.
This is no longer useful, we took out the stacktrace printing. Taking it out.
| return nil, errors.E(op, pn.pkg.UniquePath, err) | ||
| } | ||
| // print a new line after a pipeline running | ||
| pr.Printf("\n") |
There was a problem hiding this comment.
This is the original code.
There was a problem hiding this comment.
Aha, I remember that I added this. :0
frankfarzan
approved these changes
May 5, 2021
frankfarzan
pushed a commit
to frankfarzan/kpt
that referenced
this pull request
Jun 3, 2021
* kpt fn render ensures validators don't mutate resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
kpt fn renderensures that validators in a pipeline don't mutate the resources.This is achieved by splitting the execution of
mutatorsfromvalidators. Now we run validators on a copy of mutated resources.Note: It will be nice if
kpt fn rendercan flag a validator function that mutates the resources. I think that is doable, but need be investigated how best to do that.fixes #1860