Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eval render reference docs #2172

Merged
merged 2 commits into from Jun 6, 2021
Merged

Fix eval render reference docs #2172

merged 2 commits into from Jun 6, 2021

Conversation

phanimarupaka
Copy link
Contributor

This PR is to fix reference docs of render and eval.

frankfarzan
frankfarzan reviewed Jun 6, 2021
View reviewed changes
Copy link
Contributor

@frankfarzan frankfarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the double dash issue in the book as well

frankfarzan
frankfarzan approved these changes Jun 6, 2021
View reviewed changes
Copy link
Contributor

@frankfarzan frankfarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after fixing the book

@phanimarupaka
Copy link
Contributor Author

lgtm after fixing the book

Fixed

@phanimarupaka phanimarupaka merged commit 07d0269 into kptdev:next Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankfarzan frankfarzan frankfarzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phanimarupaka @frankfarzan