Add tests to verify the cli output for kpt pkg update #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanimarupaka
suggested changes
Jun 14, 2021
internal/util/pkgutil/pkgutil.go
Outdated
| @@ -239,9 +239,16 @@ func RootPkgFirstSorter(paths []string) func(i, j int) bool { | |||
| if jPath == "." { | |||
| return false | |||
| } | |||
| // First sort based on the number of segments. | |||
| // TODO: Verify whether this works on Windows. It looks like it | |||
| // probably wont. | |||
| iSegmentCount := len(strings.Split(iPath, "/")) | |||
There was a problem hiding this comment.
You can use this instead.
phanimarupaka
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few tests to verify the output from the
kpt pkg updatecommand. In particular, make sure information about deletion/addition of packages are communicated to the user.