Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added debugging info to pre-hook #2341

Merged
merged 2 commits into from Jun 25, 2021
Merged

added debugging info to pre-hook #2341

merged 2 commits into from Jun 25, 2021

Conversation

droot
Copy link
Contributor

@droot droot commented Jun 25, 2021 •
edited

This PR:

  • makes the logs for pre-hook more informative by showing the the git diff
  • It also replaced the go get to go install in relevant Makefile targets to avoid updating the go.mod file.
  • It also does go mod tidy for pkg that was updated recently (shlex).

natasha41575
natasha41575 approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm

@droot droot requested a review from phanimarupaka June 25, 2021 19:31
@droot droot merged commit baecb44 into kptdev:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortent mortent mortent approved these changes

@natasha41575 natasha41575 natasha41575 approved these changes

@phanimarupaka phanimarupaka phanimarupaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@droot @mortent @natasha41575 @phanimarupaka