New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid printing the error twice #2530

Merged

mengqiy merged 1 commit into main from mengqiy-patch-1

Oct 6, 2021

Contributor

mengqiy commented Oct 2, 2021 •

edited

We set the 3rd argument noPrintError to false in cmd := command.Build(p, command.StandaloneDisabled, false). We don't need to do fmt.Println

This is similar to GoogleContainerTools/kpt-functions-catalog#609


          Avoid printing the error twice

037ebfa

mengqiy requested review from droot, frankfarzan and phanimarupaka as code owners

October 2, 2021 07:02

mengqiy assigned droot

droot approved these changes

View reviewed changes

mengqiy merged commit 3187fe3 into main

mengqiy deleted the mengqiy-patch-1 branch

October 6, 2021 22:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment