fix: report NotFound status for deleted KCC resources #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead.
mortent
approved these changes
Jan 29, 2022
|
Thanks @rquitales for the timely fix. |
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
* fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples!
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples!
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
* fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples!
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples!
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples!
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples!
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples!
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples!
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples! Main Save inventory information into resourcegroup.yaml (kptdev#2615) Fix site sidebar to also show annotation references (kptdev#2734) effective customizations chapter (kptdev#2659) merging this as an MVP and will iterate based on additional requests and customer feedback. docs: Describe how reconcile status is computed for Config Connector resources (kptdev#2739) Mods: Merge main into porch Main feat: enable migrating from Kptfile & CM to resourcegroup inventories (kptdev#2705) This commit enables `kpt live migrate` to migrate inventory information from either a ConfigMap or Kptfile to a separate ResourceGroup file. This functionality is currently behind a feature gate and is not exposed to the user via any CLI flags. Enabling of this feature to users will be done later. make kpt binary optional in test harness (kptdev#2758) feat: enable STDIN apply and destroy using RG inventory (kptdev#2709) This commit enables actuation from STDIN using inventory information that is stored in a ResourceGroup file. This feature is currently behind a feature gate and will be exposed to users as a CLI flag in a future commit/PR. updated the version to 1.0.0-beta.13 (kptdev#2806) Merge main into porch Correct Apache License Text (kptdev#2675) LICENSE file is supposed to be an exact copy of https://www.apache.org/licenses/LICENSE-2.0.txt.
martinmaly
pushed a commit
to martinmaly/kpt
that referenced
this pull request
Feb 18, 2022
Add structs for ResourceGroup objects (kptdev#2619) * feat: Add structs for ResourceGroup objects This commit introduces the required types to move inventory information out from thee Kptfile and into a separate resourcegroup.yaml resource file. Since the ResourceGroup CRD was hard coded previously, and ResourceGroup objects were always handled as unstructured objects, these type definitions did not exist prior to this commit. * refactor: Rename default meta struct for ResourceGroup propose ownership change to facilitate PR reviews and improving kpt.dev docs (kptdev#2679) docs: update kpt completion docs (kptdev#2673) This change makes two key updates to the completion docs: - Provide instructions to remove an artifact of previous installations which breaks kpt completion functionality. This issue was reported by a user of kpt. - Direct the user to the help command for per-shell instructions to enable kpt completion. Since the completion functionality is provided by a third party library (cobra), this ensures the user is provided with accurate and up to date instructions. Ensure release license file exists (kptdev#2682) * ci: ensure existence of lib.zip for releases ensure existence of the lib.zip file for downstream releases. This is done by creating a base zip file containing a README and updating it with mozilla_repos if mozilla_repos is not empty. * ci: use array for mozilla_repos Update mozilla_repos to use an array rather than a string with space delimited elements. This is intended to provide a more straightforward type for storing a list of elements as well as provide more explicit word splitting in line with SC2086. fix: report NotFound status for deleted KCC resources (kptdev#2689) * fix: report NotFound status for deleted KCC resources The current custom StatusReader for Config Connector resources will report Unknown status when a Config Connector resource is not found (aka deleted). This causes the `kpt live destroy` reconcile loop to run forever since it expects a NotFound status to end. This commit ensures that deleted resources report a NotFound status instead. * refactor: Fix linting issue for unkeyed fields in composite literal Fix missing colon in design doc (kptdev#2693) This helps people that copy and paste from the examples! Main Save inventory information into resourcegroup.yaml (kptdev#2615) Fix site sidebar to also show annotation references (kptdev#2734) effective customizations chapter (kptdev#2659) merging this as an MVP and will iterate based on additional requests and customer feedback. docs: Describe how reconcile status is computed for Config Connector resources (kptdev#2739) Mods: Merge main into porch Main feat: enable migrating from Kptfile & CM to resourcegroup inventories (kptdev#2705) This commit enables `kpt live migrate` to migrate inventory information from either a ConfigMap or Kptfile to a separate ResourceGroup file. This functionality is currently behind a feature gate and is not exposed to the user via any CLI flags. Enabling of this feature to users will be done later. make kpt binary optional in test harness (kptdev#2758) feat: enable STDIN apply and destroy using RG inventory (kptdev#2709) This commit enables actuation from STDIN using inventory information that is stored in a ResourceGroup file. This feature is currently behind a feature gate and will be exposed to users as a CLI flag in a future commit/PR. updated the version to 1.0.0-beta.13 (kptdev#2806) Merge main into porch Correct Apache License Text (kptdev#2675) LICENSE file is supposed to be an exact copy of https://www.apache.org/licenses/LICENSE-2.0.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current custom StatusReader for Config Connector resources will
report Unknown status when a Config Connector resource is not found (aka
deleted). This causes the
kpt live destroyreconcile loop to runforever since it expects a NotFound status to end. This commit ensures
that deleted resources report a NotFound status instead.
A new test case for deleted KCC resource is also added.
Fixes: #2687