store the actuation/reconcile status in the inventory object #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlkfi
reviewed
Feb 22, 2022
karlkfi
reviewed
Feb 22, 2022
karlkfi
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
/lgtm
I don't know if i have permission to approve here, but this looks solid.
@Liujingfang1 says that new fields will be ignored by the apiserver if the CRD hasn't been updated, and these are all new fields. So this should be a safe addition.
mortent
reviewed
Feb 23, 2022
In the Store() function, it saves the actuation and reconcile status in the InventoryResourceGroup object. In the GetObject() function, it constructs the unstructured object of the ResourceGroup CR with .status.resourceStatuses assigned. Updated the unit test to cover this change.
mortent
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
Store()function, it saves the actuation and reconcile status inthe InventoryResourceGroup object.
In the
GetObject()function, it constructs the unstructured object ofthe ResourceGroup CR with .status.resourceStatuses assigned.
Updated the unit test to cover this change.