Simplify Plan resource #3182
Merged
Simplify Plan resource #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
requested review from
droot,
justinsb,
mengqiy,
martinmaly,
natasha41575 and
yuwenma
as code owners
mortent
force-pushed
the
SimplifyPlanOutput
branch
2 times, most recently
from
92de2a3
to
c2ff091
Compare
droot
reviewed
May 20, 2022
internal/cmdplan/command.go
Outdated
| ioStreams genericclioptions.IOStreams, | ||
| ) error { | ||
| planResource, err := yaml.Parse(strings.TrimSpace(` | ||
| apiVersion: config.google.com/v1alpha1 |
There was a problem hiding this comment.
Agree. Updated to use kpt.dev/v1alpha1.
mortent
force-pushed
the
SimplifyPlanOutput
branch
from
c2ff091
to
742dc94
Compare
justinsb
approved these changes
May 28, 2022
| } | ||
| rn, err := yaml.Parse(string(b)) | ||
|
|
||
| sNode, err := planResource.Pipe(yaml.LookupCreate(yaml.SequenceNode, "spec", "actions")) |
There was a problem hiding this comment.
Q: Why not use "normal" marshalling? Is it because we want to preserve comments in the yaml? Can we add a (code) comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on some of the comments from #3123:
beforetooriginal, and the one containing the resource after the apply (i.e. the resource returned by the APIServer on a dry-run) is renamed fromaftertoupdated.originalandupdatedproperties no longer contains a nestedobjectproperty (as a result of marshaling an Unstructured object), but contains the resources directly underneath.Plantype.