feat: disable client-side throttling #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable client-side throttling when server-side throttling is enabled. Otherwise default to 30 QPS (60 burst QPS). This is an increase from the rest.Config default of 5 QPS.
karlkfi
requested review from
droot,
justinsb,
mengqiy,
mortent,
natasha41575 and
yuwenma
as code owners
|
My performance testing results:
These times are for applying 1,000 Nginx Deployments with 1 replica each into an existing Namespace on a Kind v0.12.0 cluster running K8s v1.23.4. |
droot
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise default to 30 QPS (60 burst QPS).
This is an increase from the rest.Config default of 5 QPS.
Based on my local performance testing, it looks like kpt v1.0.0-beta.16 has a performance regression that defaults the applier to 5 QPS. I haven't quite figured out why, but earlier versions (like v1.0.0-beta.15) are much faster.
This change both fixes the regression and removes the QPS limit on servers where server-side throttling is enabled. The beta feature flag is enabled by default on K8s v1.20+.