Include the Config Connector status reader in the status watcher #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
requested review from
droot,
justinsb,
mengqiy,
natasha41575 and
yuwenma
as code owners
mortent
force-pushed
the
UseConfigConnectorStatusReader
branch
from
dc66b1b
to
e8eeb30
Compare
mortent
force-pushed
the
UseConfigConnectorStatusReader
branch
from
e8eeb30
to
fe00842
Compare
mortent
changed the title
mortent
force-pushed
the
UseConfigConnectorStatusReader
branch
from
9510dc6
to
d67ed57
Compare
droot
approved these changes
Aug 9, 2022
chunglu-chou
pushed a commit
to chunglu-chou/kpt
that referenced
this pull request
Aug 20, 2022
…dev#3433) * Include the Config Connector status reader in the status watcher * Fixed issues * More fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where we didn't include the custom status reader for Config Connector resources when we switched from the StatusPoller to the StatusWatcher.
This also updates to use cli-utils from the master branch, so we need to make sure we have a release before the next kpt release.
We should also remove the remaining places where we still use the poller (the
live statusandlive install-resource-groupcommands), but I want to do that in a separate PR