Use kStatus to compute status #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @mortent |
After applying the object, compute the status using the kStatus library.
justinsb
force-pushed
the
kstatus_is_the_way
branch
from
f1ab8b2
to
9f9f3af
Compare
mortent
approved these changes
Jan 26, 2023
| case status.CurrentStatus: | ||
| tracker.isHealthy = true | ||
| case status.InProgressStatus: | ||
| // TODO: Do we want a different status here? |
There was a problem hiding this comment.
I would think so. It is useful to be able to distinguish between resources that are making progress on reconciliation and those that are doomed.
There was a problem hiding this comment.
Yes, I think we can probably "bubble up" the kStatus values, reuse the work you've done there to think about what these values should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After applying the object, compute the status using the kStatus library.