-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add command for deletion proposal of porch package revisions #3745
Conversation
Propose deletion of a published package revision. | ||
--> | ||
|
||
`propose-delete` proposes a published package revision for deletion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hold off on the docs update until release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably isn't a big deal, the next release should happen late next week I think. But in general we probably want to hold off on these until we have a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg! I'll take the docs out of this PR and make a separate one that we can merge at the time of release. Also I realized that we should also have a way for cli users to change the lifecycle from DeletionProposed back to Published, so I will create that in a followup as well.
83e5a36
to
a100d28
Compare
Propose deletion of a published package revision. | ||
--> | ||
|
||
`propose-delete` proposes a published package revision for deletion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably isn't a big deal, the next release should happen late next week I think. But in general we probably want to hold off on these until we have a release.
a100d28
to
cb224f5
Compare
cb224f5
to
b10a9e4
Compare
The CLI counterpart of #3678 - adds a command
kpt alpha rpkg propose-delete
to propose deletion of published package revisions.