Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add command for deletion proposal of porch package revisions #3745

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

natasha41575
Copy link
Contributor

The CLI counterpart of #3678 - adds a command kpt alpha rpkg propose-delete to propose deletion of published package revisions.

Propose deletion of a published package revision.
-->

`propose-delete` proposes a published package revision for deletion.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we hold off on the docs update until release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably isn't a big deal, the next release should happen late next week I think. But in general we probably want to hold off on these until we have a release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg! I'll take the docs out of this PR and make a separate one that we can merge at the time of release. Also I realized that we should also have a way for cli users to change the lifecycle from DeletionProposed back to Published, so I will create that in a followup as well.

@natasha41575 natasha41575 force-pushed the proposeDeletionCLI branch 9 times, most recently from 83e5a36 to a100d28 Compare January 24, 2023 23:32
commands/alpha/rpkg/propose-delete/command.go Outdated Show resolved Hide resolved
commands/alpha/rpkg/rpkgcmd.go Outdated Show resolved Hide resolved
Propose deletion of a published package revision.
-->

`propose-delete` proposes a published package revision for deletion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably isn't a big deal, the next release should happen late next week I think. But in general we probably want to hold off on these until we have a release.

@natasha41575 natasha41575 merged commit 6b7f4a6 into kptdev:main Jan 27, 2023
@natasha41575 natasha41575 deleted the proposeDeletionCLI branch January 27, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants