Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packagevariant controller should unpropose deletion when needed #3759

Merged

Conversation

natasha41575
Copy link
Contributor

Ran into this scenario when playing around with the packagevariant controller:

  • I create a PackageVariant with a target downstream package foo. The PackageVariant controller creates the target draft package revision, and I publish it, resulting in foo v1.
  • I update the PackageVariant's target downstream package name to something else, like bar. The PackageVariant controller creates a new target draft package revision bar. It also sees that it owns a package revision foo v1 that no longer matches its target, so proposes foo v1 for deletion. This is working great so far.
  • I update the PackageVariant's target downstream package name back to foo. The PackageVariant controller deletes its package revision bar. The controller also sees that there is already a package revision foo v1 that it owns that matches its target, so it does nothing -- meaning that foo v1 stays proposed for deletion. This PR makes it so that in such a case, the target package revision's lifecycle gets changed back from DeletionProposed to Published.

@natasha41575 natasha41575 merged commit 1cb21f9 into kptdev:main Jan 27, 2023
@natasha41575 natasha41575 deleted the PackageVariantDeletionProposed branch January 27, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants