Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porch cli: command to reject deletion proposal of published packagerevs #3761

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Jan 27, 2023

This adds a way to reject a proposal of deletion of a published package revision (i.e. change the lifecycle from DeletionProposed back to Published) via kpt alpha rpkg reject.

@natasha41575 natasha41575 changed the title command to reject deletion proposal of published packagerevs porch cli: command to reject deletion proposal of published packagerevs Jan 27, 2023
@natasha41575 natasha41575 force-pushed the deletionProposedCLI branch 2 times, most recently from 570b1c8 to 3474146 Compare January 27, 2023 19:37
@mortent
Copy link
Contributor

mortent commented Jan 27, 2023

Using a flag on the propose-delete command seems inconsistent with the existing UX. I can think of two other alternatives that I think I like better:

  • Let the reject command undo both proposed deletion and publishing. So the cli will just check the current state of the packagerevision and then chose to either move it back to draft or published.
  • If we want a flag for reject a proposed deletion, add that flag to the reject command rather than the propose-delete command.

The third option if of course to just add a separate reject-delete command, but it seems a bit unnecessary.

@johnbelamaric
Copy link
Contributor

Using the reject command for both seems like the better UX to me.

@natasha41575
Copy link
Contributor Author

Using the reject command for both seems like the better UX to me.

Will do! Ty @johnbelamaric and @mortent for the suggestions

@natasha41575 natasha41575 force-pushed the deletionProposedCLI branch 4 times, most recently from 443e34c to dd98df7 Compare January 30, 2023 19:31
@natasha41575 natasha41575 marked this pull request as draft January 30, 2023 19:37
@natasha41575 natasha41575 marked this pull request as ready for review January 30, 2023 19:37
@natasha41575 natasha41575 merged commit 5a7e65f into kptdev:main Jan 31, 2023
@natasha41575 natasha41575 deleted the deletionProposedCLI branch January 31, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants