Update to golang 1.20.6 #4013
Merged
Update to golang 1.20.6 #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
reviewed
Jul 28, 2023
| @@ -24,7 +24,7 @@ jobs: | |||
| - name: Set up Go 1.20 | |||
| uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: '>=1.20.5' | |||
There was a problem hiding this comment.
We might be able to use 'stable' here (for things where we are running go but not necessarily building artifacts): https://github.com/actions/setup-go#using-stableoldstable-aliases. But OTOH that might be more confusing than just having one, explicitly specified version.
There was a problem hiding this comment.
Yeah, I agree. But we have had quite a few CVE's come up about go, so on the other hand it is useful to be explicit about which version we are using.
justinsb
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to golang 1.20.6 due to CVE-2023-29406