Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack:CI/CD tooling to verify manifests #148

Closed
ahmetb opened this issue Aug 7, 2018 · 2 comments · Fixed by #151
Closed

hack:CI/CD tooling to verify manifests #148

ahmetb opened this issue Aug 7, 2018 · 2 comments · Fixed by #151
Assignees
@lbb

Comments

@ahmetb
Copy link
Member

ahmetb commented Aug 7, 2018

We should have a way of doing some sanity checks on the plugin files to prevent:

  • the entire index from breaking due to bad yaml
  • bad links/sha (at the time of merging the PR)

Perhaps we can find the changed yaml files and do krew install --source=$f to verify installation.
@lbb
Copy link
Contributor

lbb commented Aug 20, 2018

I'll work on it

@ahmetb
Copy link
Member Author

ahmetb commented Aug 20, 2018

A brief proposal (in an issue) would be nice as opposed to an initial implementation. I suspect we should host this in main krew repo (in cmd/*).

@ahmetb ahmetb transferred this issue from kubernetes-sigs/krew-index Jan 23, 2019
@ahmetb ahmetb changed the title CI/CD tooling to verify manifests hack:CI/CD tooling to verify manifests Jan 25, 2019
This was referenced Feb 3, 2019
Closed
Merged
ahmetb added a commit that referenced this issue Feb 4, 2019
@ahmetb
cmd/validate-krew-manifest: initial implementation (#151)
50fc264 
This tool takes a manifest file and runs certain validation steps. It's meant
to test plugin manifests added to [krew-index](https://github.com/GoogleContainerTools/krew-index) install correctly (so far it has
found one broken manifest).

Fixes #148.
Related to #149 but doesn't fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbb lbb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/validate-krew-manifest: initial implementation ahmetb/krew
2 participants
@ahmetb @lbb