Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm repo add for skaffold init #2653

Open
balopat opened this issue Aug 14, 2019 · 3 comments
Open

helm repo add for skaffold init #2653

balopat opened this issue Aug 14, 2019 · 3 comments
Labels
area/init deploy/helm help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@balopat
Copy link
Contributor

balopat commented Aug 14, 2019

See #2039 for context.

This assumes that we can somehow detect the helm repos from the users helm charts and then try a helm repo add during skaffold init. We need to understand this better. Help wanted!

@balopat balopat added help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request deploy/helm priority/p3 agreed that this would be good to have, but no one is available at the moment. area/init labels Aug 14, 2019
@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@nkubala nkubala removed this from the Icebox [P2+] milestone May 11, 2021
@briandealwis
Copy link
Member

I think this needs to be done on a Skaffold build: consider the case where a developer is trying to do a build on a new machine, where no Helm repositories have been configured.

So the Helm builder should ensure Helm repositories are defined for all of the remote repositories referenced in the skaffold.yaml and in the chart dependencies.

@bouckj
Copy link

bouckj commented Apr 1, 2022

From my understanding, skaffold init just helps to build an initial skaffold.yaml file. Adding support to it for Helm configuration would be nice, but the helm add ... and helm install ... commands should probably still be performed on deploy to accommodate those of us creating our own custom skaffold.yaml. The skaffold init could at least create the necessary skaffold deploy: config to connect to a Helm repo on deploy though.

There is one integral piece of functionality that is related to this Helm configuration I believe Skaffold is currently missing: the ability to authenticate to a private Helm repo via the deploy: process. The repo and remoteChart options currently allow a remote Helm repo to be used in deploy, but there are a couple of options that are necessary to allow authentication to private repositories. I propose adding username and password options to make those current Helm authentication options usable to Skaffold.

I go into greater detail on that issue here: #7255

This Skaffold example that highlights repo and remoteChart options should also be updated to provide examples for how to add authentication to private Helm repos:

https://github.com/GoogleContainerTools/skaffold/tree/main/examples/helm-remote-repo

@zarinfam
Copy link

zarinfam commented Nov 23, 2023

I had this problem as well, but I solved it by removing the helm repo name from remoteChart in the skaffold.yaml file:
old file:

deploy:
  helm:
    releases:
      - name: prometheus-operator
        repo: https://prometheus-community.github.io/helm-charts
        remoteChart: prometheus-community/kube-prometheus-stack

new one:

deploy:
  helm:
    releases:
      - name: prometheus-operator
        repo: https://prometheus-community.github.io/helm-charts
        remoteChart: kube-prometheus-stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/init deploy/helm help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

5 participants