Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum instead of string for "InProgress" , "Succeeded", "Started", "Failed" #2967

Open
tejal29 opened this issue Oct 1, 2019 · 0 comments
Open

Use enum instead of string for "InProgress" , "Succeeded", "Started", "Failed" #2967

tejal29 opened this issue Oct 1, 2019 · 0 comments
Labels
area/eventing bugbash/q4-2022 Issues related to Skaffold Bugbash Q4 2022 help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/todo implementation task/epic for the skaffold team priority/p3 agreed that this would be good to have, but no one is available at the moment.
Milestone
Skaffold Bugbash ...

Comments

@tejal29
Copy link
Member

tejal29 commented Oct 1, 2019 •
edited by aaron-prindle

Expected behavior

Currently we have "Build Complete", "Deploy Complete" as status messages when a build or deploy successfully complete.

While "Deploy Failed" and "Build Failed" when build or deploy failed.

After discussion with IDE teams, they mentioned we could change it to "Succeeded" instead of "Complete" to be in sync with "Failed".
@tejal29 tejal29 added area/eventing kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug. labels Oct 1, 2019
@Multiply Multiply mentioned this issue Oct 3, 2019
Merged
7 tasks
@tejal29 tejal29 changed the title Change "Completed" status to "Succeeded" for event API Use enum instead of string for "InProgress" , "Succeeded", "Started", "Failed" Oct 9, 2019
@tstromberg tstromberg added priority/p3 agreed that this would be good to have, but no one is available at the moment. and removed priority/p1 High impact feature/bug. labels Apr 21, 2020
@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@nkubala nkubala removed this from the Icebox [P2+] milestone May 11, 2021
@aaron-prindle aaron-prindle added the bugbash/q4-2022 Issues related to Skaffold Bugbash Q4 2022 label Dec 9, 2022
@aaron-prindle aaron-prindle added the help wanted We would love to have this done, but don't have the bandwidth, need help from contributors label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/eventing bugbash/q4-2022 Issues related to Skaffold Bugbash Q4 2022 help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/todo implementation task/epic for the skaffold team priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
Skaffold Bugbash Q4 2022 - "Low Hangi...
Development

No branches or pull requests
4 participants
@tstromberg @tejal29 @aaron-prindle @nkubala