Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add includeTar/includeTools in sync block #2979

Open
loosebazooka opened this issue Oct 3, 2019 · 1 comment
Open

Add includeTar/includeTools in sync block #2979

loosebazooka opened this issue Oct 3, 2019 · 1 comment
Labels
area/sync kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@loosebazooka
Copy link
Member

This would allow containers that otherwise do not have the necessary container side tooling to use the skaffold sync features.

sync:
  includeTar: true
  # or 
  includeTools: true

more context: #2901 (comment)

@balopat
Copy link
Contributor

balopat commented Dec 17, 2019

In principal I'm okay with solving the issue of missing tar tools.

However, I do have questions towards directly adding tar tools to the container:

  1. Do we have to worry about compatibility issues across different base images / architectures ?
  2. if we would do this via a package manager command and altering the build def, that would solve 1) but it seems hard
  3. Maybe we could use an Ephemeral container that would have guaranteed tar tooling, and kubectl cp would be implemented through that?

@balopat balopat added the priority/p3 agreed that this would be good to have, but no one is available at the moment. label Dec 17, 2019
@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@nkubala nkubala removed this from the Icebox [P2+] milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sync kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

3 participants