Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why no files were synced #3921

Open
briandealwis opened this issue Apr 4, 2020 · 0 comments
Open

Explain why no files were synced #3921

briandealwis opened this issue Apr 4, 2020 · 0 comments
Labels
area/logging help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@briandealwis
Copy link
Member

I encountered a puzzling message when diagnosing an error on Stack Overflow involving syncing. My file sync was failing with the following error:

Syncing 1 files for testappacr.azurecr.io/test-app-admin:4c76dec58e1ef426b89fd44e3b340810db96b6961c5cacfdb76f62c9dc6725b8
WARN[0043] Skipping deploy due to sync error: copying files: didn't sync any files

This error message comes from:

if numSynced == 0 {
return errors.New("didn't sync any files")
}

The message doesn't provide any real insight as to why nothing was synced.

Ultimately the root cause was that I had disabled the status checks while I was getting the setup to work as they prevent seeing useful logs. I only discovered the pod was failing due to a missing PVC there was a problem after poking around with kubectl describe. So there were no running containers to copy the file to.

So:

  • sync.Perform() could track and report some more information on exceptional conditions: no running pods found, no matching containers found
  • perhaps the status checks could, perhaps after some amount of time, do a describe on the items that aren't healthy?

(This is related to #1571 but that issue was closed a while back and references different part of the code.)

@briandealwis briandealwis added help wanted We would love to have this done, but don't have the bandwidth, need help from contributors area/logging labels Apr 4, 2020
@balopat balopat added kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Apr 6, 2020
@nkubala nkubala added this to the Icebox milestone Sep 1, 2020
@nkubala nkubala removed this from the Icebox [P2+] milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging help wanted We would love to have this done, but don't have the bandwidth, need help from contributors kind/feature-request priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

No branches or pull requests

3 participants