Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Event emissions with tests #4102

Open
balopat opened this issue May 4, 2020 · 1 comment
Open

Cover Event emissions with tests #4102

balopat opened this issue May 4, 2020 · 1 comment
Labels
area/build area/cache area/cleanup area/debug area/deploy area/dev area/eventing kind/todo implementation task/epic for the skaffold team meta/testing Issues focused on testing Skaffold itself

Comments

@balopat
Copy link
Contributor

balopat commented May 4, 2020

We should test what type of events we are sending and when.
Currently we do not have coverage over this, and the IDEs do depend on this behavior, so the situation is somewhat precarious, easy to break them.
@balopat balopat added meta/testing Issues focused on testing Skaffold itself kind/todo implementation task/epic for the skaffold team area/eventing area/build area/cache area/cleanup area/debug area/deploy area/dev labels May 4, 2020
@briandealwis
Copy link
Member

@MarlonGamez I think this issue has been addressed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build area/cache area/cleanup area/debug area/deploy area/dev area/eventing kind/todo implementation task/epic for the skaffold team meta/testing Issues focused on testing Skaffold itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briandealwis @balopat