Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Debugger Should Support debugpy and ptvsd #4437

Closed
cpvandehey opened this issue Jul 1, 2020 · 9 comments · Fixed by #5576
Closed

Python Debugger Should Support debugpy and ptvsd #4437

cpvandehey opened this issue Jul 1, 2020 · 9 comments · Fixed by #5576
Assignees
Labels
Milestone

Comments

@cpvandehey
Copy link

cpvandehey commented Jul 1, 2020

Expected behavior

Currently ptvsd is the only DAP supported by skaffold for python apps. Microsoft is deprecating ptvsd for debugpy -- debugpy link. debugpy has a lot of the bug fixes revolving around debugging multiprocess python applications that ptvsd does not have (the press release is here). skaffold should consider making the debug package configurable or converting over to debugpy exclusively once it gets out of beta (or even now for that matter).

In the meantime, I will be inserting the command arguments manually in order to use debugpy locally and specifying a debug port in the portForwarding section (replacing skaffold debug for now with a manual process -- e.g. "-m", "debugpy", "--listen", "0.0.0.0:5000",...).

  • Skaffold version: latest
  • Operating system: mac
  • Contents of skaffold.yaml: n/a
@briandealwis
Copy link
Member

Needs to be coordinated with GoogleContainerTools/container-debug-support

@cpvandehey
Copy link
Author

Let me know if I need to file this ticket somewhere else or notify anyone

@briandealwis
Copy link
Member

@briandealwis
Copy link
Member

Will get to this in August.

@nkubala nkubala added this to the Icebox [P2+] milestone Sep 1, 2020
@cpvandehey
Copy link
Author

Any update @briandealwis ?

@tejal29
Copy link
Member

tejal29 commented Oct 26, 2020

@briandealwis looks like this should be closed now?

@briandealwis
Copy link
Member

Not yet: I've added debugpy to the duct-tape images (still needs to be regenerated), but I need to fix debug to reference debugpy now.

@cpvandehey
Copy link
Author

Thank you all. Let me know how I can follow the relevant release for this.

@briandealwis briandealwis modified the milestones: Icebox [P2+], v1.18.0 Dec 8, 2020
@briandealwis
Copy link
Member

It looks like we can rewrite gunicorn command-lines as python -m debugpy --listen :PORT -m gunicorn.app.wsgiapp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants