Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel root not detected properly when using bzlmod #9319

Open
dmeijboom opened this issue Feb 21, 2024 · 0 comments · May be fixed by #9320
Open

Bazel root not detected properly when using bzlmod #9319

dmeijboom opened this issue Feb 21, 2024 · 0 comments · May be fixed by #9320

Comments

@dmeijboom
Copy link

Expected behavior

Skaffold should recognize the bazel root correctly for projects without a WORKSPACE file (when using bzlmod).

Actual behavior

Skaffold only recognizes WORKSPACE or WORKSPACE.bazel as the bazel root. With bzlmod a workspace file is no longer required while a MODULE or MODULE.bazel file is.

Information

  • Skaffold version: v2.10.0
  • Operating system: macOs 14.2.1
  • Installed via: Homebrew
  • Contents of skaffold.yaml:
apiVersion: skaffold/v3
kind: Config
build:
  artifacts:
    - image: test
      bazel:
        target: //test-image.tar

Steps to reproduce the behavior

  1. a clonable repository with the sample skaffold project
  2. Setup bazel with bzlmod (only a BUILD and MODULE file)
  3. skaffold build
  4. fail!
@dmeijboom dmeijboom changed the title Skaffold Bazel root not detected properly when using bzlmod Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant