Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popups: Done button has fixed width and no padding #11016

Closed
swissspidy opened this issue Mar 22, 2022 · 0 comments · Fixed by #13225
Closed

Popups: Done button has fixed width and no padding #11016

swissspidy opened this issue Mar 22, 2022 · 0 comments · Fixed by #13225
Labels
Group: Patterns Includes features like color picker and overlays Group: Saved Styles Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P2 Should do soon Type: Bug Something isn't working

Comments

@swissspidy
Copy link
Collaborator

Bug Description

Things like saved styles or the color picker open in a popup.

These popups have a "Done" button to close it.

This button has a fixed with of 32px and no padding. The word "Done" barely fits in it.

In other languages, the translation of "Done" is likely longer so has even less space to fit.

Expected Behaviour

The button should have some padding and perhaps only a min-width, but not a fixed width.

Steps to Reproduce

Open saved styles popup or color picker and you'll see it right away

Screenshots

Screenshot 2022-03-22 at 13 30 26

Screenshot 2022-03-22 at 13 29 35

Screenshot 2022-03-22 at 13 28 43

Screenshot 2022-03-22 at 13 28 29

Screenshot 2022-03-22 at 13 28 20

Additional Context

  • Plugin Version: 1.18.0
  • WordPress Version: 5.9
  • Operating System: macOS
  • Browser: Chrome
@swissspidy swissspidy added Type: Bug Something isn't working P2 Should do soon Pod: Prometheus Group: Patterns Includes features like color picker and overlays Group: Saved Styles Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar labels Mar 22, 2022
@ayushnirwal ayushnirwal mentioned this issue Apr 20, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: Patterns Includes features like color picker and overlays Group: Saved Styles Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P2 Should do soon Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Popups: Fix done button in color picker and saved text styles GoogleForCreators/web-stories-wp
1 participant
@swissspidy