Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcode: Fatal error when passing empty string $attribute #13431

Closed
AnuragVasanwala opened this issue Jul 25, 2023 · 0 comments · Fixed by #13432
Closed

Shortcode: Fatal error when passing empty string $attribute #13431

AnuragVasanwala opened this issue Jul 25, 2023 · 0 comments · Fixed by #13432
Assignees
@AnuragVasanwala
Labels
Group: Shortcodes Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Bug Something isn't working
Milestone
1.34.0

Comments

@AnuragVasanwala
Copy link
Collaborator

Bug Description

Fatal error: Uncaught TypeError: Google\Web_Stories\Shortcode\Embed_Shortcode::render_shortcode(): Argument #1 ($attributes) must be of type array, string given at /web-stories-wp/includes/Shortcode/Embed_Shortcode.php on line 60.

Expected Behaviour

No fatal error. Fix is similar to the issue #13262.

Steps to Reproduce

  1. Insert shortcode block in post editor
  2. Insert [web_stories_embed /]
  3. Try to save post
  4. Get errors

Screenshots

Not required.

Additional Context

  • Plugin Version: 1.33.0
  • WordPress Version: 6.2
  • Operating System:
  • Browser:
@AnuragVasanwala AnuragVasanwala added the Type: Bug Something isn't working label Jul 25, 2023
@AnuragVasanwala AnuragVasanwala added this to the 1.34.0 milestone Jul 25, 2023
@AnuragVasanwala AnuragVasanwala self-assigned this Jul 25, 2023
@AnuragVasanwala AnuragVasanwala added P2 Should do soon Group: WordPress Changes related to WordPress or Gutenberg integration Group: Shortcodes labels Jul 25, 2023
@AnuragVasanwala AnuragVasanwala mentioned this issue Jul 25, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnuragVasanwala AnuragVasanwala

Labels
Group: Shortcodes Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Bug Something isn't working
Projects
None yet
Milestone
1.34.0
Development

Successfully merging a pull request may close this issue.

Shortcode: Properly handle case where no attributes are passed GoogleForCreators/web-stories-wp
1 participant
@AnuragVasanwala