Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database migration for disabling autoload for our options #13701

Open
swissspidy opened this issue May 23, 2024 · 4 comments
Open

Add database migration for disabling autoload for our options #13701

swissspidy opened this issue May 23, 2024 · 4 comments
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Enhancement New feature or improvement of an existing feature Type: Performance Performance related issues and enhancements.
Milestone

Comments

@swissspidy
Copy link
Collaborator

Task Description

Noticed while reviewing #13700.

On my local site our options were all autoloaded for some reason. They shouldn't be; especially when we do the cache priming.

We could add a database migration that runs once to call wp_set_options_autoload() for all our options to disable autoloading.

Not sure if it's really needed though and whether it's worth it.

Also: the function is only available in WP 6.4+

@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature Group: WordPress Changes related to WordPress or Gutenberg integration Type: Performance Performance related issues and enhancements. P3 Nice to have labels May 23, 2024
@swissspidy swissspidy added P2 Should do soon and removed P3 Nice to have labels May 30, 2024
@swissspidy swissspidy added this to the 1.37.0 milestone May 30, 2024
@swissspidy swissspidy modified the milestones: 1.37.0, 1.38.0 Jun 17, 2024
@Swanand01
Copy link
Collaborator

Hi @swissspidy, should we get started with this since we have bumped up WP version requirement to 6.4?

@swissspidy
Copy link
Collaborator Author

Counter question: on your development site, are the Web Stories options set to autoload or not? I'm trying to understand whether this was an issue only on my site, or if it affects other sites as well.

In theory they shouldn't be, in which case we wouldn't really need this migration (except for peace of mind)

@Swanand01
Copy link
Collaborator

Counter question: on your development site, are the Web Stories options set to autoload or not? I'm trying to understand whether this was an issue only on my site, or if it affects other sites as well.

In theory they shouldn't be, in which case we wouldn't really need this migration (except for peace of mind)

I can see some options being autoloaded:
image

@swissspidy
Copy link
Collaborator Author

Interesting 👀

Let me check this on some other sites to see if there's a pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Enhancement New feature or improvement of an existing feature Type: Performance Performance related issues and enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants