Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete doesn't work immediately after undo #1852

Closed
o-fernandez opened this issue May 19, 2020 · 2 comments · Fixed by #2261
Closed

Delete doesn't work immediately after undo #1852

o-fernandez opened this issue May 19, 2020 · 2 comments · Fixed by #2261
Labels
Group: History P2 Should do soon Type: Bug Something isn't working

Comments

@o-fernandez
Copy link
Contributor

Bug Description

If you undo a deletion, then press the del key right after, the element is not deleted.

Expected Behaviour

It should delete as usual.

Steps to Reproduce

  1. Add text element to page
  2. Click on page to deselect the text element
  3. Re-select the text element
  4. Press delete key, see element get deleted
  5. Press cmd+z or ctrl+z to undo, element reappears and is shown as selected
  6. Press delete key again -- notice that the element is not deleted.

Workaround: Need to deselect and re-select the item in order to delete.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@miina
Copy link
Contributor

miina commented May 20, 2020

This should be a duplicate of #1781

@miina
Copy link
Contributor

miina commented May 20, 2020

The issue here is that the Delete shortcut isn't working globally -- clicking anywhere resulting in losing focus of the Page will disable using Delete shortcut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: History P2 Should do soon Type: Bug Something isn't working
Projects
None yet
3 participants