Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a prependMedia/updateMediaElements context actions for useUploadMedia #2072

Closed
cvolzke4 opened this issue May 28, 2020 · 1 comment
Closed

Add a prependMedia/updateMediaElements context actions for useUploadMedia #2072

cvolzke4 opened this issue May 28, 2020 · 1 comment
Labels
Group: Media P3 Nice to have Status: Duplicate This issue or pull request already exists Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️

Comments

@cvolzke4
Copy link
Contributor

cvolzke4 commented May 28, 2020 •
edited

As it is now, useUploadMedia consumes the 'media' attribute (ie. the array of the media resources) in order to prepend uploaded media resources. This is inefficient, and adds an unnecessary dependency to the 'media' attribute inside of useUploadMedia.

As an alternative, a 'prependMedia' and/or updateMediaElements context actions can be added to add the uploaded media resources instead.
@cvolzke4 cvolzke4 mentioned this issue May 28, 2020
Merged
@swissspidy swissspidy added Group: Media Pod: Media I/O Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ labels May 28, 2020
@cvolzke4 cvolzke4 changed the title Add a prependMedia context action for useUploadMedia Add a prependMedia/updateMediaElements context actions for useUploadMedia Jun 3, 2020
@dreamofabear dreamofabear added the P3 Nice to have label Sep 22, 2020
@swissspidy swissspidy added the Status: Duplicate This issue or pull request already exists label Jul 1, 2021
@swissspidy
Copy link
Collaborator

prependMedia was implemented in #6541. See also #2513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: Media P3 Nice to have Status: Duplicate This issue or pull request already exists Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swissspidy @dreamofabear @cvolzke4