Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull out common reducer.js, types.js, actions.js from media/local artifacts to media/common #2428

Closed
cvolzke4 opened this issue Jun 15, 2020 · 0 comments · Fixed by #2827, #2893, #2953 or #2959
Closed

Pull out common reducer.js, types.js, actions.js from media/local artifacts to media/common #2428

cvolzke4 opened this issue Jun 15, 2020 · 0 comments · Fixed by #2827, #2893, #2953 or #2959
Assignees
@cvolzke4
Labels
Group: 3P Media Third-party media provider integrations. P1 High priority, must do soon

Comments

@cvolzke4
Copy link
Contributor

cvolzke4 commented Jun 15, 2020 •
edited

Task Description

A number of local media reducers and actions should be shared across local media and media3p including:

These should be moved from media/local/reducer.js to media/common/reducer.js. Similarly for constants in types.js and action dispatchers in actions.js.

media/local/actions.js will include stub functions that delegate their work to media/common/actions.js.
@swissspidy swissspidy added Pod: Media I/O Group: 3P Media Third-party media provider integrations. labels Jun 15, 2020
@cvolzke4 cvolzke4 changed the title Pull out common reducer.js and types.js from media/local artifacts to media/common Pull out common reducer.js, types.js, actions.js from media/local artifacts to media/common Jun 30, 2020
@cvolzke4 cvolzke4 self-assigned this Jun 30, 2020
@cvolzke4 cvolzke4 linked a pull request Jun 30, 2020 that will close this issue
Pull out common parts of local/reducer.js to media/common/reducer.js #2827
Merged
@diegovar diegovar added the P1 High priority, must do soon label Jul 1, 2020
@diegovar diegovar added this to the Sprint 32 milestone Jul 1, 2020
@cvolzke4 cvolzke4 linked a pull request Jul 1, 2020 that will close this issue
Pull media action functions out to common #2893
Merged
@cvolzke4 cvolzke4 mentioned this issue Jul 3, 2020
Merged
@cvolzke4 cvolzke4 linked a pull request Jul 3, 2020 that will close this issue
Pull out reducer type constants to local and common folders #2953
Merged
@cvolzke4 cvolzke4 linked a pull request Jul 3, 2020 that will close this issue
Remove 'local' provider specific attributes from fetchMediaSuccess #2959
Merged
@cvolzke4 cvolzke4 reopened this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvolzke4 cvolzke4

Labels
Group: 3P Media Third-party media provider integrations. P1 High priority, must do soon
Projects
None yet
Milestone
No milestone
3 participants
@diegovar @swissspidy @cvolzke4