Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer re-ordering #51

Closed
jauyong opened this issue Nov 30, 2019 · 4 comments · Fixed by #143
Closed

Layer re-ordering #51

jauyong opened this issue Nov 30, 2019 · 4 comments · Fixed by #143
Assignees
Labels
P0 Critical, drop everything

Comments

@jauyong
Copy link

jauyong commented Nov 30, 2019

Feature description

Controls that allows moving blocks backwards and forwards (e.g. behind another block or bring on top of another block). Implemented in sidebar and dedicated layer panel.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@samitron7
Copy link

Here are the behaviors for re-ordering in the layers panel. Note that the re-ordering behavior should be consistent with that for re-ordering thumbnails in the carousel and the grid view (ie we like for it to be all consistent).

Anatomy of Layers Panel:
https://www.figma.com/file/Cd9iacVknHK62RO4pRwb68/Stories-Editor?node-id=2683%3A260

Re-ordering behavior:

  1. Drag and drop
  2. Cut/paste to re-order
    https://www.figma.com/file/Cd9iacVknHK62RO4pRwb68/Stories-Editor?node-id=2715%3A1632

@swissspidy swissspidy transferred this issue from ampproject/amp-wp Jan 23, 2020
@swissspidy swissspidy added In Feature Map P0 Critical, drop everything labels Jan 23, 2020
@jauyong jauyong added this to the Sprint 21 milestone Jan 23, 2020
@barklund barklund mentioned this issue Jan 28, 2020
8 tasks
@barklund barklund reopened this Jan 29, 2020
@barklund
Copy link
Contributor

Only panel refactor has been completed - still needs actual layer panel.

@pbakaus
Copy link
Contributor

pbakaus commented Feb 25, 2020

@barklund this seems done except for the keyboard shortcuts, right?

@barklund
Copy link
Contributor

@barklund this seems done except for the keyboard shortcuts, right?

Yes, and keyboard shortcuts were actually added in #320, also merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical, drop everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants