Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload overlay clears up canvas when shown #795

Closed
wassgha opened this issue Mar 26, 2020 · 6 comments · Fixed by #970
Closed

Upload overlay clears up canvas when shown #795

wassgha opened this issue Mar 26, 2020 · 6 comments · Fixed by #970
Assignees
Labels
Group: Media Type: Bug Something isn't working

Comments

@wassgha
Copy link
Contributor

wassgha commented Mar 26, 2020

Bug Description

This might not have been clear from the Figma since it uses an empty page but the drag and drop upload overlay on the canvas should be displayed as an overlay on top of any existing elements and should not be clearing up the page when shown

Screenshots

ezgif com-video-to-gif (35)

/cc @dvoytenko if you wanna take it, otherwise assign it to me


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@dvoytenko
Copy link
Contributor

I believe this is intentional by @samitron7, to remove the misunderstanding that dnd on canvas can target any particular placement and not to be confused with drop targets.

@samitron7
Copy link

samitron7 commented Mar 27, 2020

Wassim is correct. Sorry if it wasn't clear but the scrim is an overlay.
Group 4595

@wassgha wassgha assigned wassgha and unassigned samitron7 Mar 29, 2020
@wassgha
Copy link
Contributor Author

wassgha commented Mar 29, 2020

@dvoytenko I'll take this as part of the refactor I'm doing for dnd

@dvoytenko
Copy link
Contributor

Sure. To clarify though: this just involves removing the screen over the page area, right? I added an extra element on top specifically to support what I thought was required to completely screen out the content. There shouldn't be otherwise any structure issues, right?

@wassgha
Copy link
Contributor Author

wassgha commented Mar 30, 2020

I was planning to do some renaming since the Dropzone name will be free after #803 is merged and try to simplify the structure by attempting to combine the two drop zones since the text is now simply centered in both directions, with no need to use the css grid structures

@dvoytenko
Copy link
Contributor

That all sounds good. The grid strcuture/css should already be used there. I think the only delta is that we no longer need these three lines: https://github.com/google/web-stories-wp/blob/13ec65435bfa54332c5937a21cc423a58b53dd28/assets/src/edit-story/components/canvas/canvasUploadDropTarget.js#L103-L105. Or maybe they will just look different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Media Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants