-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload overlay clears up canvas when shown #795
Comments
I believe this is intentional by @samitron7, to remove the misunderstanding that dnd on canvas can target any particular placement and not to be confused with drop targets. |
@dvoytenko I'll take this as part of the refactor I'm doing for dnd |
Sure. To clarify though: this just involves removing the screen over the page area, right? I added an extra element on top specifically to support what I thought was required to completely screen out the content. There shouldn't be otherwise any structure issues, right? |
I was planning to do some renaming since the Dropzone name will be free after #803 is merged and try to simplify the structure by attempting to combine the two drop zones since the text is now simply centered in both directions, with no need to use the css grid structures |
That all sounds good. The grid strcuture/css should already be used there. I think the only delta is that we no longer need these three lines: https://github.com/google/web-stories-wp/blob/13ec65435bfa54332c5937a21cc423a58b53dd28/assets/src/edit-story/components/canvas/canvasUploadDropTarget.js#L103-L105. Or maybe they will just look different. |
Bug Description
This might not have been clear from the Figma since it uses an empty page but the drag and drop upload overlay on the canvas should be displayed as an overlay on top of any existing elements and should not be clearing up the page when shown
Screenshots
/cc @dvoytenko if you wanna take it, otherwise assign it to me
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions
The text was updated successfully, but these errors were encountered: