Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify edge cases of using bold markup and bold font weights #925

Closed
dvoytenko opened this issue Apr 1, 2020 · 2 comments · Fixed by #1323
Closed

Clarify edge cases of using bold markup and bold font weights #925

dvoytenko opened this issue Apr 1, 2020 · 2 comments · Fixed by #1323
Assignees
@o-fernandez
Labels
Elements: Text P2 Should do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@dvoytenko
Copy link
Contributor

dvoytenko commented Apr 1, 2020 •
edited by jauyong

Feature Description

The following edge cases would be good to clarify:

  1. When a 700+ weight is selected, should we auto-toggle "B" button
  2. If the "B" button then untoggled, should we set the weight back to 400
  3. If a 900 weight is selected, and the bold shortcut is used on the selection, what should happen? If the bold shortcut is used again on the same selection, should it return to 900? 700?
    3a. Bold shortcut on selection should always go back to 400, and to 700 vice versa. The only way to select other weights are via dropdown in the design panel.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions
@dvoytenko dvoytenko added the Type: Enhancement New feature or improvement of an existing feature label Apr 1, 2020
@dvoytenko dvoytenko mentioned this issue Apr 1, 2020
Closed
@pbakaus
Copy link
Contributor

pbakaus commented Apr 2, 2020

  1. Yes.
  2. Yes.
  3. Bold shortcut on selection should always go back to 400, and to 700 vice versa. The only way to select other weights are via dropdown in the design panel.

Reminder to self to update relevant product spec..

@jauyong jauyong added the P2 Should do soon label Apr 7, 2020
This was referenced Apr 23, 2020
Closed
Merged
@pbakaus
Copy link
Contributor

pbakaus commented May 2, 2020

@o-fernandez could you make sure the spec fixed if needed here?

@pbakaus pbakaus assigned o-fernandez and unassigned pbakaus May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@o-fernandez o-fernandez

Labels
Elements: Text P2 Should do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inline text formatting GoogleForCreators/web-stories-wp
5 participants
@pbakaus @dvoytenko @swissspidy @jauyong @o-fernandez