Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testing workflow more convenient #302

Closed
ukabu opened this issue Jun 14, 2016 · 3 comments
Closed

Make testing workflow more convenient #302

ukabu opened this issue Jun 14, 2016 · 3 comments

Comments

@ukabu
Copy link

ukabu commented Jun 14, 2016

Right now, we cannot do a clone of the repo, install dependencies and run tests.

Instead, we have to bower install google-map and then run tests from within the bower_components folder structure (see #81). This is really backward.

I suggest that test cases use ../bower_components/[path] instead of ../../[path] in their script tags.

This would make contributing to this repo much more convenient.

@ebidel
Copy link
Contributor

ebidel commented Jun 14, 2016

This is the recommended approach for https://github.com/Polymer/web-component-tester. However, when running the tests in a repo checkout, this works for me:

git clone git@github.com:GoogleWebComponents/google-map.git
cd google-map;
bower install
wct -l chrome

@ebidel ebidel closed this as completed Jun 14, 2016
@ukabu
Copy link
Author

ukabu commented Jun 15, 2016

They do run from the command line.

However, they don't load when served using a web server(used polymer serve) and opened in the browser.

@ebidel
Copy link
Contributor

ebidel commented Jun 15, 2016

I see. You may want to suggest this over on that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants