Improve dev script #468
Improve dev script #468
Conversation
| const path = require('path'); | ||
| const rollup = require('rollup'); |
There was a problem hiding this comment.
These weren't actually being used so I 🔥 them.
rollup.config.dev.js
Outdated
| }; | ||
|
|
||
| const plugins = [ | ||
| resolve(), |
There was a problem hiding this comment.
I removed clean here in hopes that it would speed up builds.
rollup.config.dev.js
Outdated
| } | ||
|
|
||
| warn(warning); | ||
| }; |
There was a problem hiding this comment.
I recognize this code could be put in it's module. I can do this in this PR if you all want.
| const path = require('path'); | ||
| const rollup = require('rollup'); |
|
I'm cool with |
|
It would make it easier to be specific about what we want in dev vs prod without sharing code and / or duplicating configuration. And, we could have more than just dev and prod scenarios (what about test?). |
| const resolve = require('rollup-plugin-node-resolve'); | ||
| const cleanup = require('rollup-plugin-cleanup'); | ||
|
|
||
| const {NODE_ENV} = process.env; |
There was a problem hiding this comment.
I think using NODE_ENV has become a standard so 🤷♂️
|
I've updated to use |
| @@ -31,7 +31,8 @@ | |||
| ], | |||
| "scripts": { | |||
| "clean": "rm -rf ./lib ./dist", | |||
| "build": "tsc && rollup -c", | |||
| "build": "tsc && rollup -c --environment NODE_ENV:production", | |||
| "build:dev": "tsc && rollup -c --environment NODE_ENV:development", | |||
| const resolve = require('rollup-plugin-node-resolve'); | ||
| const cleanup = require('rollup-plugin-cleanup'); | ||
|
|
||
| const {NODE_ENV} = process.env; |
|
Thanks @mikkoh, my dev day today speed up considerably 🙏 |
|
🙌 I might look into it more and see if we can make some more speedups. |
This PR does two things. Makes
devwatch.tsfiles also and attempts to improve build speed forwatch.So I've seen #235 which is more extensive where it breaks out tests etc.
I'm putting this out there to bring this up as a discussion again.
Even after this PR
buildtakes ~2sec to run which is not nice. I'm not actually sure why builds take so long. Might investigate at some point.