Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AR feature cleanup #501

Merged
merged 7 commits into from Apr 24, 2019
Merged

AR feature cleanup #501

merged 7 commits into from Apr 24, 2019

Conversation

cdata
Copy link
Contributor

@cdata cdata commented Apr 23, 2019

This change implements some minor cleanup of our AR feature, including:

  • Some related modules converted to TypeScript
  • Better names for things
  • Slot-ified the AR button

@cdata cdata requested a review from smalls April 23, 2019 19:00
smalls
smalls previously approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@smalls smalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cdata cdata merged commit 68d91a7 into master Apr 24, 2019
@cdata cdata deleted the ar-updates branch April 24, 2019 16:22
@cdata cdata added this to the v0.3.1 milestone Apr 26, 2019
@cdata cdata mentioned this pull request May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalls smalls smalls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdata @smalls