New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default interaction policy to always-allow #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think I would like to see this paired with a way for folks to opt-in to requiring focus until such time as we implement #479 . LMK if you have time to add an attribute for that, otherwise I can layer it on!
I can likely handle it, but it will be next week. |
@cdata I added in the attribute interaction-policy so users can opt-in to requiring focus. This name came from the internal attribute that is currently being used.
|
Agreed, there is a bit of repetition here. I think in the long-run, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change requested, otherwise looks great 🍻
Changes made :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 👍
From all of our user testing it seems clear that requiring focus on mobile to interact is not intuitive. @mrdoob said the same thing over at #479.
I do think we need a better heuristic for mobile (#479), and we should have the interaction policy be configurable (#500), but a sensible default should favor making it easy to interact with.
Thoughts?