Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom global variables are discouraged and have naming rules #2

Open
mudrd8mz opened this issue Apr 27, 2020 · 0 comments
Open

Custom global variables are discouraged and have naming rules #2

mudrd8mz opened this issue Apr 27, 2020 · 0 comments

Comments

@mudrd8mz
Copy link

Using custom global variables is discouraged.

If there are valid good reasons for having them in plugins, their names should follow the naming conventions.

Your plugin uses a custom global variable STATEADDITIONALDATA.

  • Are there valid reasons for having to have such global variable?
  • If so, I would expect its name should start with AUTH_AZUREB2C_ prefix - i.e. same rules as for constants. But really, ideally to avoid it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mudrd8mz