Editorial fix: Rename [coroutine.handle.import.export] to [coroutine.handle.export.import] to be consistent with the section header and the order in which definitions appear #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne_handle`'s `from_address` method.
…ained via a prior call to address()". This is wrong - "address()" is an expression producing a void* (which cannot be called). "address" is what we want to say here.
…ss method definition (it is declared constexpr in the synopsis).
…omise>::from_address have different return types.
…handle.export.import] to be consistent with the section header and the order in which definitions appear.
brycelelbach
force-pushed
the
editorial_fix_rename_coroutine_handle_import_export_stable_tag
branch
from
b24a347
to
fbf0213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR is rebased against #4, so I'd review that one first
In the class synopsis for
coroutine_handle<>in [coroutine.handle], this section is referred to as "export/import", and the export function (address) is listed before the import function (from_address). Likewise, in the definitions for these two methods in [coroutine.handle.import.export], the section is titled "Export/import" andaddressappears first. Sincefrom_addressmentionsaddress, this seems like the correct order to list things in as it avoids adding forward references to the spec.I'd like to rename this stable tag from [coroutine.handle.import.export] to [coroutine.handle.export.import] [as an editorial change before PTDS.