Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about attetion #4

Closed
Liaoqing-up opened this issue Apr 28, 2022 · 0 comments
Closed

A question about attetion #4

Liaoqing-up opened this issue Apr 28, 2022 · 0 comments

Comments

@Liaoqing-up
Copy link

Hello, it's impressive work and it's pleasure to read your code. And i have a question about the details in attention module... In the paper, the BEV feature is added by attentioned RV feature, but in the code below, the bev feature is added twice, one in ConvAttentionLayer_Decouple and one in self.residual_add. From my point of view, it should be only add once in second place. Is there any special design or is it experimentally proven to work better? Forward for your replay~

temp_view = view + r

bev_output_feat_map = self.residual_add(bev_feat_map, bev_atten_output, bev_kernel_size).contiguous()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants