Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional holidays marked as national in locale de-DE #53

Closed
lauft opened this issue Jun 19, 2020 · 0 comments
Closed

Regional holidays marked as national in locale de-DE #53

lauft opened this issue Jun 19, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lauft
Copy link
Member

lauft commented Jun 19, 2020

Describe the bug
The following holidays have flag N (i.e. are national holidays) but have regions defined.

  • Which holidays are affected?
    01-06: [BW,BY,ST] [NRF] Heilige drei Könige
    08-15: [SL] [NRF] Mariä Himmelfahrt
    11-01: [BW,BY,NW,RP,SL] [NRF] Allerheiligen
    60 days after Easter: [BW,BY,HE,NW,RP,SL] [NRV] Fronleichnam
    11 days before 4. sunday before 12-25: [SN] [NRV] Buß- und Bettag
    10-31: [*] [NRF] Reformationstag*
    03-08: [BE] [NF] Frauentag
    2020-05-08: [BE] [NF] 75. Jahrestag der Befreiung vom Nationalsozialismus und der Beendigung des Zweiten Weltkrieges in Europa
    
    *Holiday "Reformationstag" is a national holiday only in 2017
  • Which years does the bug affect?
    All years

Expected behavior
If a holiday has regions defined, it should not have flag N.

@lauft lauft added the bug Something isn't working label Jun 19, 2020
@lauft lauft self-assigned this Jun 19, 2020
@lauft lauft closed this as completed in 8d75ae1 Jun 19, 2020
@lauft lauft mentioned this issue Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant