Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using week numbers accounts Sunday through Saturday, not Monday through Sunday #595

Open
smemsh opened this issue Mar 13, 2024 · 0 comments

Comments

@smemsh
Copy link
Contributor

smemsh commented Mar 13, 2024

Week numbers would typically be ISO weeks, but they seem to include the Sunday from the previous week, and not include the Sunday from the given week. For example:

timew summary 2024-W10 - 2024-W11

includes Sunday from W9 and does not include Sunday from W10. This differs from [imo correct] behavior of :week and :lastweek which use Monday based weeks. I would think week number would correspond exactly to date +%V.

This was tested with timew-1.7.1 and its pegged libshared.

Got the week syntax from src/libshared/test/datetime.t.cpp. Was not sure if the bug should be filed in libshared repo, but it seems to be library-user-specific since :week and :lastweek are working as expected, but let me know if this should be moved there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant