New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bypass for `AnyNullEncoder` when wrapped in `Immutable` #25

Merged

GottaGetSwifty merged 1 commit into GottaGetSwifty:master from jayrhynas:immutable-encodenulls

Feb 9, 2022

Contributor

jayrhynas commented Feb 9, 2022 •

edited

NullEncoding.swift includes a specific override of encode for AnyNullEncoder (NullEncoding.swift) to bypass the default behaviour of OptionalEncodingWrapper which would otherwise skip the property when the wrappedValue is nil.

However, Immutable also overrides encoding of wrapped OptionalEncodingWrappers (ImmutableWrapper.swift) to check if the deeply nested wrappedValue is nil or not, which means the above AnyNullEncoder override is never called.

This PR adds an additional bypass for AnyNullEncoders wrapped in AnyImmutableWrapper.


          Added bypass for AnyNullEncoder when wrapped in Immutable

7e1b8c1

Fixes `EncodeNulls` being skipped when the wrappedValue is `nil`

jayrhynas mentioned this pull request

@Immutable @EncodeNulls doesn’t work as expected #24

Closed

jayrhynas force-pushed the immutable-encodenulls branch from 3c38cee to 7e1b8c1 Compare

February 9, 2022 16:45

sonarcloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

Owner

GottaGetSwifty commented Feb 9, 2022

Looks good, thanks for validating with a Test!

GottaGetSwifty merged commit 65c19ad into GottaGetSwifty:master

jayrhynas deleted the immutable-encodenulls branch

February 9, 2022 22:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment