Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion opening and closing animation #1

Closed
gouravkhunger opened this issue Oct 1, 2021 · 9 comments · Fixed by #2
Closed

Accordion opening and closing animation #1

gouravkhunger opened this issue Oct 1, 2021 · 9 comments · Fixed by #2
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gouravkhunger
Copy link
Owner

gouravkhunger commented Oct 1, 2021

The accordion just toggles the visibility of the text for now. It would be great if the text has a sliding down animation on being visible, and a sliding up animation on being dismissed.

Check line 152 of Accordion.kt file

@gouravkhunger gouravkhunger added good first issue Good for newcomers enhancement New feature or request labels Oct 1, 2021
@xtanion
Copy link
Contributor

xtanion commented Oct 3, 2021

I can give it a try, can you assign it to me please 😄

@gouravkhunger
Copy link
Owner Author

Sure, go ahead :)

@gouravkhunger
Copy link
Owner Author

Sorry, assigned to myself by mistaked 😂

xtanion added a commit to xtanion/AccoLib that referenced this issue Oct 3, 2021
@xtanion
Copy link
Contributor

xtanion commented Oct 3, 2021

@gouravkhunger I've submitted my PR, please have a look at it, Thank You.

@xtanion
Copy link
Contributor

xtanion commented Oct 3, 2021

I can add a gif or video of the sample if you want 😃

@gouravkhunger
Copy link
Owner Author

Sure, adding the gif would help me to merge it faster, else I have to clone and test myself 😂

@xtanion
Copy link
Contributor

xtanion commented Oct 3, 2021

2021_10_03_19_53_39.mp4

@gouravkhunger I have attached a sample animation.

@gouravkhunger
Copy link
Owner Author

Hey that's good, but the thing is I have tried this approach, the problem here is that there is duel animation.

If you slow down this animation and look at the frames, you would see that a space comes down before the actual texts is sliding down, and I wanted something that would make the text animate all on itself and make its space as it comes down.

Right now, it is first creating some space for itself, and then showing the animation.

Thanks a lot for the PR, if you could resolve the above issue, then I would be really happy to merge it :)

@xtanion
Copy link
Contributor

xtanion commented Oct 3, 2021

Sure, I'll try to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants