Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the option to show the last page in the pagination components #213

Closed
2 tasks done
xyngfei opened this issue Feb 1, 2024 · 1 comment
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@xyngfei
Copy link

xyngfei commented Feb 1, 2024

Prerequisites

Proposal

Is there any page to improve the pagination components?
https://www.designsystem.tech.gov.sg/components/pagination

If I look the the sample from sgds site, it will display the last page to allow the user to select. However, refer to the storybook, the example does not have the sample to display the last page in the pagination components

https://react.designsystem.tech.gov.sg/?path=/docs/components-pagination--basic

Any idea how if I wish to display last page in the pagination components?

Motivation and context

To let user have the option to navigate to the last page directly.

@clukhei
Copy link
Collaborator

clukhei commented Mar 25, 2024

@xyngfei the pagination props for first page and last page are exposed in v2.4.0

<Pagination
... 
showLastPage={true}
/>

Storybook controls example:
https://react.designsystem.tech.gov.sg/?path=/story/components-pagination--basic&args=showLastPage:true

@clukhei clukhei closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants