Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design of current combobox is not screen-reader accessible, because there is no visible button to open the menu #137

Open
clukhei opened this issue Oct 3, 2023 · 0 comments

Comments

@clukhei
Copy link
Collaborator

clukhei commented Oct 3, 2023

@rav3 Design of current combobox is not screen-reader accessible, because there is no visible button to open the menu (see https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-autocomplete-list/).

Currently, the input box acts as both input and button to open the menu. I need to add both aria roles combobox and button to the input box, which is not possible.

The button role is needed so that the user can click to open the menu via the screen-reader. Indicating only the combobox role is not sufficient.

Could the designers look into this? 🙏

@jmestxr @clukhei
Could you take alook at the figma. See if the new design will solve the issue
https://www.figma.com/file/vxEBjIkXXkxaB89h4OzUVV/branch/QTOmxVUru44yH45kvu4Exe/SGDS-Components-V2.0.0?type=design&node-id=5181%3A2072&mode=design&t=tRYiRresDUqMmkZV-1

Originally posted by @rav3 in #128 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant