Unmet peer dependency warning for @popperjs/core which is requested by bootstrap when using Yarn

[jmalvinez]

Prerequisites

• I have searched for duplicate or closed issues
• I have read the contributing guidelines

Describe the issue

Hi team, we're using Yarn as our package manager and noticed the warning below when installing our dependencies which includes @govtechsg/sgds-web-component.

➤ YN0002: │ @govtechsg/sgds-web-component@npm:1.0.2 doesn't provide @popperjs/core (p4cfd4), requested by bootstrap
➤ YN0002: │ @govtechsg/sgds@npm:2.2.0 doesn't provide @popperjs/core (p62b33), requested by bootstrap
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code

This happens because one of your dependencies - bootstrap: ^5.1.3 lists @popperjs/core: ^2.11.8 as its peer dependency. Yarn doesn't automatically install peer dependencies unlike NPM >= v7.

We still get the said warning even if we add @popperjs/core to our dependencies since peer dependencies in Yarn need to be satisfied by the immediate dependant (@govtechsg/sgds-web-component), and not just somewhere (multiple steps) up the dependency chain.

Perhaps you could consider adding @popperjs/core to your peerDependencies based on this discussion about inherting peer dependencies from your dependencies. Otherwise, you could also just add it as a direct dependency. Thanks!

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome

Describe your frontend stack. What version of React and @govtechsg/sgds-web-component are you using? CSR or SSR?

yarn v2.4.3, React v18.2.0, @govtechsg/sgds-web-component v1.0.2

[clukhei]

Hi @jmalvinez, thanks for highlighting issue. Sure , we can make the change, in our next minor version.

We also welcome contributions if you are keen, let us know 😉

[clukhei]

seems like this issue came from the @govtechsg/sgds dependency. I'll probably need to resolve it there first when im back