Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning inside the Identification Report #2

Closed
JonasGroeger opened this issue Aug 13, 2021 · 4 comments
Closed

Versioning inside the Identification Report #2

JonasGroeger opened this issue Aug 13, 2021 · 4 comments

Comments

@JonasGroeger
Copy link

JonasGroeger commented Aug 13, 2021

Hi!

I have two questions:

  1. Will the IdentificationReport adhere to the SemVer standard?
  2. Could we embed the schema version inside the example payload?

So this:

{
+   "$schema": "https://github.com/Governikus/IdentificationReport:1.0.1",
    "reportID": "be4f9806-0b5f-45c3-a008-96fd2750f8cb",
    "serverIdentity": "https://test.governikus-eid.de/gov_autent/async",
    "reportTime": "2020-06-25T10:20:39+02:00",
    "identificationDate": "2020-06-25T10:19:54+02:00",
    "idStatus": "success",
    "subjectRef":  {"firstName": "John","lastName": "Doe" },
    "contextInformation": ["Antrag auf Kindergeld: 0815/763763"],
    "idStatement": "successful identification sent by SAML-Assertion",
    "documentReferences":[{
      "documentName":"test.pdf",
      "hashAlgo":"SHA-256","digest":"0c2720631b927e25d5cb8b5ca2b9408c552ea76797e3419245931296732fd0d2"
  }],
    "loaSent": "http://eidas.europa.eu/LoA/low"
  }

The specific value of $schema is not that important as long as it somehow has the words IdentificationReport and the version in it.

We're using the IndentificationReport in FIT-Connect and require a stable version and self-identifying payload.

@mrburnsDE
Copy link
Contributor

Hi,
thanks for your comment! We will comply to the semantic versioning. I pushed an updated readme and sample. Since this is only a change on documentation and sample i didn't release a new version.

Regards
Hartje

@JonasGroeger
Copy link
Author

JonasGroeger commented Aug 23, 2021

@mrburnsDE
Copy link
Contributor

mrburnsDE commented Aug 24, 2021

Thanks for your feedback again! I updated the JWS. I cannot remember why i pushed the hints file. Maybe i used it for debugging purposes. Also removed that one.

@JonasGroeger
Copy link
Author

With pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants