Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 10 support #174

Closed
pedzed opened this issue Feb 6, 2023 · 9 comments
Closed

Add Laravel 10 support #174

pedzed opened this issue Feb 6, 2023 · 9 comments

Comments

@pedzed
Copy link

pedzed commented Feb 6, 2023

This is currently not working for Laravel 10:

$ composer require graham-campbell/markdown:^14.0
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires graham-campbell/markdown ^14.0 -> satisfiable by graham-campbell/markdown[v14.0.0, 14.0.x-dev].
    - graham-campbell/markdown[v14.0.0, ..., 14.0.x-dev] require illuminate/contracts ^8.75 || ^9.0 -> found illuminate/contracts[v8.75.0, ..., 8.x-dev, v9.0.0-beta.1, ..., 9.x-dev] but these were not loaded, likely because it conflicts with another require.


Installation failed, reverting ./composer.json and ./composer.lock to their original content.
@stefnats
Copy link

I made a PR #175

@ultrono
Copy link

ultrono commented Feb 19, 2023

FYI, for anyone coming here looking for Laravel 10 support I've forked this repository. All tests are passing with Laravel 10. See #175 (comment).

Have been running this fork now for a few days now, on a system that gets a decent amount of use, without issue.

Hopefully #175 will get merged soon 🤖

@maxxscho
Copy link

Any chances #175 gets merge soon?

@cworreschk
Copy link

@GrahamCampbell Any news on #175 ?

@dsampaolo
Copy link

@GrahamCampbell Please merge this PR :)

@GrahamCampbell
Copy link
Owner

Thanks for making a start here, though there are quite a few missing things from that PR, such as updating the readme, and the tests are currently failing. I will handle the upgrade myself, shortly. In the meanwhile, Sponsoring me is a great way to support this project, and better enable me to perform these upgrades in a timely manor. I maintain or co-maintain upwards of 100 OSS repos. 💻

@GrahamCampbell
Copy link
Owner

All tests are passing with Laravel 10. See #175 (comment).

Unfortunately, they are not. If you look closely, they are actually running on Laravel 9, not 10. This is because I have to first apply upgrades to my testbench packages.

@GrahamCampbell
Copy link
Owner

v15.0.0 has now been released, with PHP 8.2 and Laravel 10 support.

@ultrono
Copy link

ultrono commented Mar 1, 2023

Ah, good catch, didn't notice that, can see the actions file uses "matchers", which I've not come across before. My fork has been running for well over a week without issue, with a simple composer change for the Laravel version.

Not that any of this matters now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants